Bc-5596-poc-update-feathersjs-mongoose #4550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| `please set the environment variable BODYPARSER_JSON_LIMIT to min. '${Math.ceil( | ||
| 1.36 * (MAXIMUM_ALLOWABLE_TOTAL_ATTACHMENTS_SIZE_BYTE / 1024 / 1024) | ||
| )}mb' for helpdesk to work correctly! (Currently: ${BODYPARSER_JSON_LIMIT})` | ||
| ); |
There was a problem hiding this comment.
formating affected, should revert this part...
| @@ -38,7 +38,7 @@ class MockSyncerWithData extends Syncer { | |||
| } | |||
| } | |||
|
|
|||
| describe('datasourceRuns service', () => { | |||
| describe.only('datasourceRuns service', () => { | |||
| @@ -19,7 +19,7 @@ const fixtures = require('../fixtures'); | |||
| const { expect } = chai; | |||
| chai.use(chaiAsPromised); | |||
|
|
|||
| describe('filePermissionHelper', () => { | |||
| describe.only('filePermissionHelper', () => { | |||
test/services/helpdesk/index.test.js
Outdated
| @@ -5,7 +5,7 @@ const sinon = require('sinon'); | |||
| const appPromise = require('../../../src/app'); | |||
| const { Configuration } = require('@hpi-schul-cloud/commons'); | |||
|
|
|||
| describe('helpdesk service', function test() { | |||
| describe.only('helpdesk service', function test() { | |||
| @@ -17,7 +17,7 @@ chai.use(chaiAsPromised); | |||
| chai.use(chaiHttp); | |||
| const { expect } = chai; | |||
|
|
|||
| describe('LdapConfigService', () => { | |||
| describe.only('LdapConfigService', () => { | |||
| @@ -88,11 +88,8 @@ function connect() { | |||
|
|
|||
| const mongooseOptions = { | |||
| autoIndex: NODE_ENV !== ENVIRONMENTS.PRODUCTION, | |||
| poolSize: MONGOOSE_CONNECTION_POOL_SIZE, | |||
| minPoolSize: MONGOOSE_CONNECTION_POOL_SIZE, //https://mongoosejs.com/docs/migrating_to_6.html#mongodb-driver-40 ?? | |||
There was a problem hiding this comment.
Mongoose 5.x poolSize option is equivalent to the Mongoose 6 maxPoolSize option. The default value of maxPoolSize has been increased to 100.
I guess we should add a maxPoolSize too. Default seems to be 100
In dof app we have
MONGOOSE_CONNECTION_POOL_SIZE:
value: "50"
so, we had a (max) 50 and now is min 50 to 100. Will that not cause any issues?
…athersjs-mongoos
virgilchiriac
changed the title
TODO Check this https://mongoosejs.com/docs/6.x/docs/api/query.html#query_Query-updateMany the given example references nModified, so why must we change it to modifiedCount?
virgilchiriac
force-pushed
the
BC-5828-feathers-update
branch
from
4373645 to
b5c18df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
BC-5829 (BC-5596)
BC-5828 - feathers update #4568
BC-5596 - poc -update feathersjs to version 5 schulcloud-client#3346
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.